This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
[Hold] Fixes #5172 - Hide edit tool icon in Microsoft Edge #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punamdahiya
changed the title
jaredhirsch
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
This is okay as a provisional fix, but this UA sniffing approach is not an acceptable long-term practice. If we're going to maintain this server long-term, we should be using Modernizr to detect the specific canvas APIs not (yet) supported in various browsers, and polyfill them appropriately. I'll file a bug to discuss on monday.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.